java.lang.IllegalArgumentException: Can only use lower 16 bits for requestCode

[gustavo-iniguez-goya]

Reported with 1.6.0. Problematic code still present on dev branch (05/10).

Some light about the exception:
https://stackoverflow.com/questions/14378002/exception-with-android-when-using-acra

we should use an int <= 65536.

java.lang.IllegalArgumentException: Can only use lower 16 bits for requestCode : at org.csploit.android.plugins.mitm.MITM$CheckForOpenPortsTask$1.onConfirm(MITM.java:339)

public void onConfirm(){
            startActivityForResult(new Intent(MITM.this, SettingsActivity.class), SettingsActivity.SETTINGS_DONE);
          }

SettingsActivity.java:

public static final int SETTINGS_DONE = 101285;

Something like SETTINGS_DONE = 1285; should fix the problem.

[fat-tire]

I fixed the same issue here, line 48 of DirectoryPicker. We might want to do a sweep to see if this exists in other places...

[fat-tire]

Here are the ones I found:

SELECT_PICTURE, PICK_DIRECTORY, SettingsActivity.SETTINGS_DONE, SELECT_USER_WORDLIST, WIFI_CONNECTION_REQUEST

Did I miss any? Can we prefix them with ACTIVITY_ and maybe put them in one place?

[gustavo-iniguez-goya]

also SELECT_SCRIPT and SELECT_PASS_WORDLIST. I would do it.

[tux-mind]

grep -roP "[A-Z0-9_]{3,}\s_=\s_[0-9]+" cSploit/src

cSploit/src/org/csploit/android/services/UpdateService.java:NOTIFICATION_ID = 1
cSploit/src/org/csploit/android/services/UpdateService.java:DOWNLOAD_COMPLETE_CODE = 1
cSploit/src/org/csploit/android/services/UpdateService.java:CANCEL_CODE = 2
cSploit/src/org/csploit/android/services/receivers/MsfRpcdServiceReceiver.java:MSF_NOTIFICATION = 1337
cSploit/src/org/csploit/android/plugins/LoginCracker.java:SELECT_USER_WORDLIST = 1012
cSploit/src/org/csploit/android/plugins/LoginCracker.java:SELECT_PASS_WORDLIST = 1013
cSploit/src/org/csploit/android/plugins/mitm/PasswordSniffer.java:OPTIONS_FIELDS = 0
cSploit/src/org/csploit/android/plugins/mitm/PasswordSniffer.java:OPTIONS_FILTERS = 0
cSploit/src/org/csploit/android/plugins/mitm/MITM.java:SELECT_PICTURE = 1010
cSploit/src/org/csploit/android/plugins/mitm/MITM.java:SELECT_SCRIPT = 1011
cSploit/src/org/csploit/android/plugins/PacketForger.java:TCP_PROTOCOL = 0
cSploit/src/org/csploit/android/plugins/PacketForger.java:UDP_PROTOCOL = 1
cSploit/src/org/csploit/android/net/http/server/ServerThread.java:MAX_REQUEST_SIZE = 8192
cSploit/src/org/csploit/android/net/http/server/Server.java:BACKLOG = 255
cSploit/src/org/csploit/android/net/http/server/Server.java:MAX_FILE_SIZE = 10
cSploit/src/org/csploit/android/net/http/proxy/Proxy.java:BACKLOG = 255
cSploit/src/org/csploit/android/net/http/proxy/ProxyThread.java:MAX_REQUEST_SIZE = 8192
cSploit/src/org/csploit/android/net/http/proxy/ProxyThread.java:HTTP_SERVER_PORT = 80
cSploit/src/org/csploit/android/net/http/proxy/ProxyThread.java:HTTPS_SERVER_PORT = 443
cSploit/src/org/csploit/android/net/http/proxy/HTTPSRedirector.java:BACKLOG = 255
cSploit/src/org/csploit/android/net/http/proxy/StreamThread.java:CHUNK_SIZE = 1024
cSploit/src/org/csploit/android/net/metasploit/ShellSession.java:TIMEOUT = 60000
cSploit/src/org/csploit/android/gui/DirectoryPicker.java:PICK_DIRECTORY = 1212
cSploit/src/org/csploit/android/wifi/algorithms/helpers/JenkinsHash.java:MAX_VALUE = 0
cSploit/src/org/csploit/android/MainActivity.java:WIFI_CONNECTION_REQUEST = 1012
cSploit/src/org/csploit/android/SettingsActivity.java:SETTINGS_DONE = 101285
cSploit/src/org/csploit/android/core/System.java:HTTP_PROXY_PORT = 8080
cSploit/src/org/csploit/android/core/System.java:HTTP_SERVER_PORT = 8081
cSploit/src/org/csploit/android/core/System.java:HTTPS_REDIR_PORT = 8082
cSploit/src/org/csploit/android/core/System.java:MSF_RPC_PORT = 55553
cSploit/src/org/csploit/android/core/System.java:HTTP_PROXY_PORT = 8080
cSploit/src/org/csploit/android/core/System.java:HTTP_SERVER_PORT = 8081
cSploit/src/org/csploit/android/core/System.java:HTTPS_REDIR_PORT = 8082
cSploit/src/org/csploit/android/core/System.java:MSF_RPC_PORT = 55553
cSploit/src/org/csploit/android/core/MultiAttackService.java:NOTIFICATION_ID = 2
cSploit/src/org/csploit/android/core/MultiAttackService.java:CANCEL_CODE = 1
cSploit/src/org/csploit/android/core/MultiAttackService.java:CLICK_CODE = 2
cSploit/src/org/csploit/android/core/MultiAttackService.java:TRACE    = 1
cSploit/src/org/csploit/android/core/MultiAttackService.java:SCAN     = 2
cSploit/src/org/csploit/android/core/MultiAttackService.java:INSPECT  = 4
cSploit/src/org/csploit/android/core/MultiAttackService.java:EXPLOIT  = 8
cSploit/src/org/csploit/android/core/MultiAttackService.java:CRACK    = 16

[tux-mind]

thanks for the report @gainan , we're killing many bugs!

[xaitax]

You guys are killing it! 👍 👍