Skip to content

some dSploit->cSploit changes. Affects not much.#291

Merged
tux-mind merged 2 commits intocSploit:developfrom
fat-tire:develop
Sep 27, 2015
Merged

some dSploit->cSploit changes. Affects not much.#291
tux-mind merged 2 commits intocSploit:developfrom
fat-tire:develop

Conversation

@fat-tire
Copy link
Copy Markdown
Contributor

I mean, might as well, right?

A better version of this would be colored depending on what is happening.

But for now, whatever.
@fat-tire
Copy link
Copy Markdown
Contributor Author

I added a snackbar commit there too. Probably should have done it on another branch. Oh well. Feel free to accept one and not the other or what-have-you.

@tux-mind
Copy link
Copy Markdown
Member

is the snackbar working on android API 9 ?

thanks for your awesome work @fat-tire 😊

@fat-tire
Copy link
Copy Markdown
Contributor Author

I'm pretty sure the snackbar should work in api 9. From the instructions:

your applications can use the libraries' features and still be compatible with devices running Android 1.6 (API level 4) and up.

Anyone have an old gingerbread device laying around who wants to give it a shot?

Also note that the snackbar is drawn at the root view (android.R.id.content) of the activity (or the given context really), so unlike a toast it won't show up system-wide or on other activities.. ...At least I don't think it will. This was just a very fast 10 minute late-Saturday night addition- I didn't even add the colors like in the notifications, which could be supported too, so if anyone wants to build on it, feel free.

@tux-mind
Copy link
Copy Markdown
Member

I personally prefer the toast because you get notified of the connection even if you are in a different app.

I think that snackbar should be used for notification about an action performed in this moment, in that view/context.

tux-mind added a commit that referenced this pull request Sep 27, 2015
some dSploit->cSploit changes.  Affects not much.
@tux-mind tux-mind merged commit 8a36577 into cSploit:develop Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants