Settings: Use PreferenceFragmentCompat#326
Merged
fat-tire merged 3 commits intocSploit:developfrom Sep 29, 2015
Merged
Conversation
A 20% darker hex than the original holo_blue... Its supposed to be darker not lighter than the below colorPrimary
* Now use one preferences.xml file * Use PreferenceFragmentCompat and AppCompatActivity for preferences instead of PreferencesActivity * Use legal sized RequestID in DirectoryPicker; Note this was only tested a tiny bit on Lollipop. Need to try it on older devices to make sure it's okay.
Since it's done by onCreatePreferences() there is no reason to do it in onCreate(). Hey, half the preferences!
fat-tire
added a commit
that referenced
this pull request
Sep 29, 2015
Settings: Use PreferenceFragmentCompat Here goes nothin'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please test extensively at this before committing! I can not say this works on any device really. Could be tons of regressions. The idea was to fix the settings so that it can be used on older APIs as it was crashing before.
Now it uses some preferences stuff from the support library, namely a
PreferenceFragmentCompatandAppCompatActivityrather than the single old-style PreferencesActivity. In that way, it's a little more "modern" and if it works, it should work all the way down to API 9 Gingerbread.But I'm not saying it works. This is a WORK IN PROGRESS that I wanted to get in for comment/testing before I went to sleep...
Also, I am including the
style.xmlcommit too so that my patch is over that as I'm touchingstyle.xml. But you can merge it across frommaster. Accepting that tomasterwas a screwup-- should have merged intodevelop.One last thing, if you're wondering about this:
It's cuz that value wasn't defined for older APIs. And this:
Is just because that gigantic number was crashing android when it was used as a RequestCode for launching an intent:
Cheers!