Block break delay setting#4291
Merged
leijurv merged 2 commits intocabaletta:1.19.4from Mar 28, 2024
Merged
Conversation
Collaborator
|
Feels a bit odd how the actual delay is 2 more than the setting value. Is it like this for the place delay as well? |
Contributor
Author
With rightClickSpeed = 4, i'm measuring a 5 tick delay between place packets
yeah should be more clear for users, i'll update it. I think changing the rightClickSpeed setting similarly would make sense too. |
ZacSharp
approved these changes
Mar 11, 2024
Collaborator
ZacSharp
left a comment
There was a problem hiding this comment.
I think changing the rightClickSpeed setting similarly would make sense too.
Agreed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes baritone flagging FastBreak, causing it to get stuck in an endless loop sending stop break packets.
Due to how baritone calls start break slightly different (more direct) from vanilla, there is only 2 ticks from stop break to start break instead of vanilla's 6 ticks.