Skip to content

Block break delay setting#4291

Merged
leijurv merged 2 commits intocabaletta:1.19.4from
rfresh2:block-break-delay
Mar 28, 2024
Merged

Block break delay setting#4291
leijurv merged 2 commits intocabaletta:1.19.4from
rfresh2:block-break-delay

Conversation

@rfresh2
Copy link
Copy Markdown
Contributor

@rfresh2 rfresh2 commented Mar 10, 2024

Fixes baritone flagging FastBreak, causing it to get stuck in an endless loop sending stop break packets.

Due to how baritone calls start break slightly different (more direct) from vanilla, there is only 2 ticks from stop break to start break instead of vanilla's 6 ticks.

@ZacSharp
Copy link
Copy Markdown
Collaborator

Feels a bit odd how the actual delay is 2 more than the setting value. Is it like this for the place delay as well?
If not I think it would be a good idea to have the setting be the actual delay and document that values lower than 2 will be clamped.

@rfresh2
Copy link
Copy Markdown
Contributor Author

rfresh2 commented Mar 10, 2024

Is it like this for the place delay as well

With rightClickSpeed = 4, i'm measuring a 5 tick delay between place packets

have the setting be the actual delay

yeah should be more clear for users, i'll update it. I think changing the rightClickSpeed setting similarly would make sense too.

Copy link
Copy Markdown
Collaborator

@ZacSharp ZacSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing the rightClickSpeed setting similarly would make sense too.

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants