Merged
Conversation
Contributor
Author
|
In case you are reviewing with an older version of docker engine installed locally, you could try: |
yaroslavcev
reviewed
Sep 3, 2024
| go 1.22 | ||
|
|
||
| require ( | ||
| github.com/cabify/aceptadora v0.0.0-00010101000000-000000000000 |
Contributor
There was a problem hiding this comment.
I think this pseudo version was intentionally set to highlight that we use current version with replace statement later.
replace github.com/cabify/aceptadora => ../
Having particular tag might confuse reader, making him thinking that we run acceptance on an older version
Contributor
Author
There was a problem hiding this comment.
Thanks for the comment, I've added your suggestion
Contributor
Acceptance failed with Could you try adding |
aabian
force-pushed
the
aabian/bump-docker
branch
from
7b377f1 to
a52b37c
Compare
yaroslavcev
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump docker dependency to
27.2.0