Allow typescript project as parameter#138
Merged
Merged
Conversation
christiandebarrio
approved these changes
Oct 26, 2022
Contributor
christiandebarrio
left a comment
There was a problem hiding this comment.
Just a nit suggestion
alexgallardo
approved these changes
Oct 26, 2022
SaraMansori
approved these changes
Oct 26, 2022
Co-authored-by: Christian <christian.debarrio@cabify.com>
…bify/package-build-javascript into allow-typescript-project-as-parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While developing any project you expect the tools to work by default when type checking and linting, this includes this tool implementation in the IDE. Those tools use
tsconfig.jsonby default which is something expected.This configuration looks like this:
This configuration will cause
package-buildlibrary to compile all files included in the Typescript configuration. This means it will include in the bundle useless files for distribution like unit tests, storybook stories and test helpers.To avoid this we should be able to define a different file for configuration like
tsconfig.build.jsononly including library entrypoint, usuallysrc/index.ts.This configuration will avoid transforming useless files into the bundle but allow the tools to use the root
tsconfig.jsonas a reference.