Skip to content

fix: remove stale nmrs-aur submodule gitlink#331

Merged
cachebag merged 1 commit intocachebag:masterfrom
okhsunrog:fix/remove_submodule
Apr 9, 2026
Merged

fix: remove stale nmrs-aur submodule gitlink#331
cachebag merged 1 commit intocachebag:masterfrom
okhsunrog:fix/remove_submodule

Conversation

@okhsunrog
Copy link
Copy Markdown
Contributor

As discussed earlier, nothing much to say here.
Dropping the gitlink unblocks cargo dependency resolution.

@cachebag cachebag enabled auto-merge (rebase) April 9, 2026 17:47
@cachebag cachebag added the bug Something isn't working label Apr 9, 2026
@okhsunrog
Copy link
Copy Markdown
Contributor Author

@cachebag can you do a patch release after this one? So I don't have to keep a git dependency

@cachebag
Copy link
Copy Markdown
Owner

cachebag commented Apr 9, 2026

@cachebag can you do a patch release after this one? So I don't have to keep a git dependency

Yes sir. Will cut a release as soon as I'm home from work.

@cachebag cachebag merged commit 2490a46 into cachebag:master Apr 9, 2026
6 checks passed
okhsunrog added a commit to okhsunrog/archinstall_zfs that referenced this pull request Apr 9, 2026
Both of our PRs on upstream nmrs have merged:
- cachebag/nmrs#330 (Send bound on for_each_access_point)
- cachebag/nmrs#331 (stale nmrs-aur gitlink removal)

The latest published crates.io release (2.2.0) still predates both,
so we stay on a git patch until a new version is cut — but the
patch now points at upstream master pinned to commit 352f57e
instead of our local fork branch.

The old fork branch `okhsunrog/nmrs#fix/send-bounds-for-each-ap`
becomes unreferenced after this; it can stay around as a safety
net or be deleted at any time since upstream has the same content.

Drop this [patch.crates-io] block entirely once nmrs cuts a new
release and bump core/Cargo.toml's nmrs constraint to it.

Verified all four slint-ui + tui profiles build clean against
the upstream pin (linuxkms, desktop, desktop-mock, tui) and
core wifi tests still pass.
@cachebag
Copy link
Copy Markdown
Owner

@cachebag can you do a patch release after this one? So I don't have to keep a git dependency

@okhsunrog Sorry for the delay! nmrs 2.3.0 is published and the AUR for nmrs-gui is now on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants