fix(#334): use zvariant::Dict for vpn.data and vpn.secrets dbus types#337
Merged
cachebag merged 1 commit intodev-openvpnfrom Apr 10, 2026
Merged
fix(#334): use zvariant::Dict for vpn.data and vpn.secrets dbus types#337cachebag merged 1 commit intodev-openvpnfrom
zvariant::Dict for vpn.data and vpn.secrets dbus types#337cachebag merged 1 commit intodev-openvpnfrom
Conversation
cachebag
changed the title
zvariant::Dict for vpn.data and vpn.secrets dbus types
There was a problem hiding this comment.
Pull request overview
Fixes OpenVPN settings encoding so vpn.data and vpn.secrets are sent over D-Bus with the a{ss} (dict string→string) signature required by NetworkManager, preventing silent rejection/activation failures.
Changes:
- Added a helper to convert
Vec<(String, String)>into azvariant::Dictwitha{ss}signature. - Updated
build_openvpn_connectionto serialize bothvpn.dataandvpn.secretsusing that dict representation. - Added a unit test checking the produced dict signature.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_openvpn_connectionwas encodingvpn.dataandvpn.secretsasVec<(String, String)>, whichValue::fromserializes asa(ss)(array of struct pairs). NetworkManager expectsa{ss}(dict of string to string) and silently rejects or fails activation with the wrong type. Replaced both with azvariant::Dicthelper that produces the correcta{ss}signature.Closes #334.