Clean up ibm-semeru-openj9 and graalvm version string quirk handling #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Partially assisted by Claude Code; any errors are mine.)
No longer needed becaues upstream index now provides pre-merged `ibm-semeru`. (Assisted by Claude Code; any errors are mine.)
It also simplifies the example because `native-image` is bundled since GraalVM for JDK 17 (`gu` is no longer available).
Instead of allowing version components to be strings, remove the specific strings. The only strings that actually appear are '_openj9-' and '-m2'. I don't know what -m2 means but openj9 is definitely not a version element. Normalize to all numbers, taking into account that '.' binds more strongly than '+' (presumably) -- so zero-pad to 4 elements before the '+'. Version strings containing _openj9- but not containing '+' are skipped as invalid. (Assisted by Claude Code; any errors are mine.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both now have clean variants in the upstream index, so document recommended vendor names.
Remove
ibm-semeru-openj9-java*merging because the upstream indexibm-semerudoes that.Simplify
ibm-semeru-openj9-java*version normalization and avoid string elements in normalized versions. This also fixes some sorting/comparing bugs.Update GraalVM example in docs to use
graalvm-community.