ci: buffer fuzz timeout above max_total_time so libFuzzer self-exits#40
Open
27Bslash6 wants to merge 1 commit into
Open
ci: buffer fuzz timeout above max_total_time so libFuzzer self-exits#4027Bslash6 wants to merge 1 commit into
27Bslash6 wants to merge 1 commit into
Conversation
The outer `timeout` wrapping `cargo fuzz run` must exceed -max_total_time. libFuzzer's clock starts after build + corpus-load, so an equal timeout always wins the race and SIGTERMs the process before its graceful "Done" self-exit — every run then logs "run interrupted", making a genuine hang indistinguishable from normal end-of-budget completion. - Quick Fuzz: timeout 120 -> 150 (max_total_time stays 120, +30s slack) - Deep Fuzzing: timeout 28800 -> 28980 (max_total_time stays 28800, +3min slack, within 540min job cap) Exit code 124 (genuine hang killed by timeout) remains tolerated.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated security workflow timeout handling for libFuzzer fuzzing jobs. Quick Fuzz outer timeout increased from 120 to 150 seconds, Deep Fuzz from 28800 to 28980 seconds, both preserving their inner ChangesFuzzing workflow timeout tuning
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Widen the outer
timeoutwrappingcargo fuzz runin both the Quick Fuzz and Deep Fuzzing jobs so it sits above libFuzzer's-max_total_time, not equal to it.timeout-max_total_timeWhy
libFuzzer self-exits gracefully at
-max_total_timewith a finalDone N runs+ corpus consolidation. Its clock starts after build + corpus-load, so an equal outertimeoutalways wins the race — it SIGTERMs the process first, every run logsrun interrupted, and a genuine hang becomes indistinguishable from normal end-of-budget completion. The buffer makestimeouta hang safety-net only.Exit code 124 (timeout fired = real hang) remains tolerated.
Notes
ci:type — non-releasing, does not trigger release-please.Summary by CodeRabbit
Release Notes