fix: lazy-load ArrowSerializer to avoid ImportError without pyarrow #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrowSerializer was unconditionally imported at module load time, causing ImportError for users who install cachekit without the [data] extra (pyarrow). Changes: - Remove top-level ArrowSerializer import - Add lazy loading via _get_arrow_serializer() helper - Use __getattr__ for lazy attribute access - Update SERIALIZER_REGISTRY to use None placeholder - Fix benchmark_serializers and get_serializer_info to handle lazy loading gracefully Users can now: - pip install cachekit and use default serializers - pip install cachekit[data] to enable ArrowSerializer Fixes #41
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Add 14 unit tests for lazy loading mechanism
- Test _get_arrow_serializer(), __getattr__, get_serializer('arrow')
- Test benchmark_serializers() and get_serializer_info() with lazy loading
- Add unit conftest to skip Redis isolation for pure unit tests
- Include Windows platform.node() fix (cherry-picked from #43)
- Format: whitespace in conftest.py - CVE: urllib3 2.6.1 → 2.6.3 (GHSA-g4mx-q9vg-27p4) - Type: add type:ignore for hasattr-guarded get_info() call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ArrowSerializerimport that broke users without pyarrow_get_arrow_serializer()helper__getattr__for lazy attribute access on modulebenchmark_serializersandget_serializer_infoto handle lazy loadingTest plan
pip install cachekitworks without pyarrowfrom cachekit import cachesucceedsget_serializer('arrow')raisesImportErrorwhen pyarrow missingpip install 'cachekit[data]'enables ArrowSerializerFixes #41