fix(swr): preserve explicit writes during refresh (LAB-751) - #84
Conversation
Co-authored-by: multica-agent <github@multica.ai>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
![kodus-27b[bot]](https://avatars.githubusercontent.com/u/223823690?s=60&v=4){kind=small}
…sion tests (LAB-751) Kody review round on #84: - Restore the WaitUntil type export on the /workers entry (and its cache-core re-export). It shipped in the published cachekit v0.1.4 — removing it as 'internal' was a breaking API change hiding in a fix PR. - Add the unit-level regression tests for the updateL1=false refresh path: a happy-path test proving completeRefresh is what lands the refreshed value in L1 (with L2 persistence verified through an L1-less reader), and a gated-backend interleaving test proving an explicit set() during an in-flight refresh wins in L1. The second test was verified to FAIL against the pre-#84 behavior (refresh clobbers L1 with the stale value). - Reword the setEntry L1 comment the review panel flagged as overclaiming: the version guard is authoritative for L1 only; the refresh's backend write remains last-write-wins in L2 (conditional writes would need CAS the Backend contract doesn't have). Co-authored-by: multica-agent <github@multica.ai>
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
@kody start-review |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Fixes the post-merge review findings from LAB-751.
SWR refreshes now persist to L2 without mutating L1; completeRefresh is the only L1 writer and retains its version-token guard, so concurrent explicit writes win. The change also avoids taking markers for null values, removes the redundant manager-level tracker that could leak on torn-down Workers isolates, and removes the internal WaitUntil re-export.
Validation:
Docs: no update needed; this corrects internal refresh lifecycle behavior without changing the documented Workers API or SWR contract.