⚡ Bolt: O(1) index maps for SwiftUI @Published toggles#229
Conversation
Replaces O(n) `firstIndex(where:)` lookups with O(1) dictionary-based index maps for toggling item selection in the UI. - Adds `scanResultsIndexMap` and `nodeModulesIndexMap` variables. - Populates index maps safely using `enumerated().reduce(into: [:])`. - Updates `toggleSelection` and `toggleNodeModulesSelection` to use maps. - Maintains backwards-compatible fallback mechanisms if map gets out-of-sync. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
Replaced O(n)
firstIndex(where:)array searches with O(1) dictionary-based index maps for UI toggles of scan results and Node modules.🎯 Why:
When users click to select or deselect a large number of cached items, relying on a linear array scan to find the item's UUID index can cause UI hiccups, especially on larger filesystems.
📊 Impact:
Provides O(1) instantaneous item selection toggling regardless of total scan result size, guaranteeing the UI thread remains unblocked when iterating large selections.
🔬 Measurement:
PR created automatically by Jules for task 13885162832263264934 started by @acebytes