fix(minting-service): rename leftover @cacheplane/* imports to @ngaf/*#150
Merged
Conversation
PR #145 (the @cacheplane → @Ngaf scope rename) missed apps/minting-service. Imports of @cacheplane/db and @cacheplane/licensing no longer resolve because the path aliases were renamed to @ngaf/*; every Vercel preview deploy of cacheplane-minting-service has been failing as a result. This commit: - renames the package itself from @cacheplane/minting-service to @ngaf/minting-service - updates the 8 import sites in handlers, src/lib, scripts to @ngaf/db and @ngaf/licensing - updates @cacheplane/* references in build.mjs comments - mirrors the package rename in package-lock.json (surgical edit, not regenerated) Verified: `npx nx build minting-service` succeeds; `npx vitest run` passes 42/42 in apps/minting-service. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@cacheplane/*→@ngaf/*scope rename) missedapps/minting-service. Imports of@cacheplane/dband@cacheplane/licensingno longer resolve because the tsconfig path aliases were renamed to@ngaf/*. Every Vercel preview deploy ofcacheplane-minting-servicesince refactor: rename npm scope @cacheplane → @ngaf; drop mcp from publishable group #145 has been failing withCould not resolve "@cacheplane/db"/"@cacheplane/licensing"esbuild errors.@cacheplane/minting-service→@ngaf/minting-service) plus all 8 import sites inhandlers/,src/lib/, andscripts/.package-lock.jsonis edited surgically (2 hunks) — not regenerated, to avoid platform-specific@next/swc-*binding drift.buildCommand,installCommand, custom domainmint.cacheplane.ai, env vars) are untouched and remain correct.Test Plan
npx nx build minting-serviceproduces.vercel/output/functions/api/health.funcandstripe-webhook.funcnpx vitest runinapps/minting-service— 42/42 passinghttps://mint.cacheplane.ai/api/healthstill returns200 {"ok":true}🤖 Generated with Claude Code