Skip to content

fix(chat,langgraph): jank — stable @for tracking + empty-array guard #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 1 commit into from
May 2, 2026
Merged

fix(chat,langgraph): jank — stable @for tracking + empty-array guard #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/chat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ngaf/chat",
"version": "0.0.8",
"version": "0.0.9",
"exports": {
".": {
"types": "./index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion libs/chat/src/lib/primitives/chat-message-list/chat-message-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function getMessageType(message: Message): MessageTemplateType {
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [CHAT_HOST_TOKENS, CHAT_MESSAGE_LIST_STYLES],
template: `
@for (message of messages(); track $index) {
@for (message of messages(); track message.id) {
@let template = findTemplate(getMessageType(message));
@if (template) {
<ng-container
Expand Down
2 changes: 1 addition & 1 deletion libs/langgraph/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ngaf/langgraph",
"version": "0.0.2",
"version": "0.0.3",
"peerDependencies": {
"@ngaf/chat": "*",
"@ngaf/licensing": "*",
Expand Down
8 changes: 7 additions & 1 deletion libs/langgraph/src/lib/internals/stream-manager.bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,10 @@ export function createStreamManagerBridge<T, ResolvedBag extends BagTemplate = B
// so optimistic human messages and earlier tool messages are preserved.
if (event.type === 'messages/partial' || event.messageMetadata) {
subjects.messages$.next(mergeMessages(subjects.messages$.value, normalized));
} else if (normalized.length === 0) {
// Defensive: skip empty replacements during streaming. An empty
// batch shouldn't tear down the entire UI (causes message DOM
// teardown + streaming renderer reset = visible jank).
} else {
subjects.messages$.next(normalized);
}
Expand All @@ -346,7 +350,9 @@ export function createStreamManagerBridge<T, ResolvedBag extends BagTemplate = B
// Also sync messages$ from the values state so the full message
// history (including human messages) is available to consumers.
const stateMessages = (vals as Record<string, unknown>)['messages'];
if (Array.isArray(stateMessages)) {
if (Array.isArray(stateMessages) && stateMessages.length > 0) {
// Defensive: only sync when state carries messages. An empty
// values payload shouldn't wipe the UI mid-stream.
if (options.toMessage) {
subjects.messages$.next(stateMessages.map(options.toMessage));
} else {
Expand Down
Loading