Skip to content

fix(cockpit): production review pass — 22 fixes across 14 examples#23

Merged
blove merged 1 commit into
mainfrom
fix/cockpit-production-review
Apr 6, 2026
Merged

fix(cockpit): production review pass — 22 fixes across 14 examples#23
blove merged 1 commit into
mainfrom
fix/cockpit-production-review

Conversation

@blove
Copy link
Copy Markdown
Contributor

@blove blove commented Apr 6, 2026

Summary

Production review of all 14 cockpit Angular examples for correctness, clarity, and learner-friendliness.

Critical fixes (2)

  • planning — broken style="{{ expr }}" interpolation → [style.color]="expr"
  • sandboxes — broken style="{{ expr }}" interpolation → [style.background]="expr"

Important fixes (10)

  • interrupts — replaced internal "Tier 3" comments with learner-friendly explanations
  • time-travel — added JSDoc explaining replay vs fork distinction
  • deployment-runtimecurrentThreadId converted to signal; hardcoded colors → CSS vars
  • 6 deep-agents — all sidebars now always visible with empty-state text
  • 4 deep-agents — replaced (msg as any).tool_calls with typed getToolCalls() API

Suggestions (5)

  • Added file-level JSDoc to persistence, time-travel, durable-execution
  • Made deployment-runtime properties protected readonly

Test plan

  • nx run-many -t build --projects='cockpit-*-angular' — all 14 build
  • nx test render && nx test chat — all pass

…ken interpolations, learner-friendly comments

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@blove blove merged commit e00b6e5 into main Apr 6, 2026
10 of 11 checks passed
@blove blove deleted the fix/cockpit-production-review branch May 7, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant