Skip to content

fix(chat): post-merge sidenav polish — semantic <nav> + rename close→closed #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blove merged 1 commit into from
May 12, 2026
Merged

fix(chat): post-merge sidenav polish — semantic <nav> + rename close→closed #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/website/content/docs/chat/api/api-docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2369,7 +2369,7 @@
"optional": false
},
{
"name": "close",
"name": "closed",
"type": "OutputEmitterRef<void>",
"description": "",
"optional": false
Expand Down
2 changes: 1 addition & 1 deletion examples/chat/angular/src/app/shell/demo-shell.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
[(query)]="searchQuery"
[results]="searchResults()"
(threadSelected)="onSearchSelect($event)"
(close)="paletteOpen.set(false)"
(closed)="paletteOpen.set(false)"
/>

<chat-debug
Expand Down
6 changes: 3 additions & 3 deletions libs/chat/src/lib/compositions/chat-sidenav/chat-sidenav.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ export type ChatSidenavMode = 'expanded' | 'collapsed' | 'drawer';
(click)="openChange.emit(false)"
></button>
}
<aside
<nav
class="chat-sidenav"
role="navigation"
aria-label="Sidebar navigation"
tabindex="-1"
(keydown.escape)="onEscape()"
>
<div class="chat-sidenav__header">
Expand Down Expand Up @@ -96,7 +96,7 @@ export type ChatSidenavMode = 'expanded' | 'collapsed' | 'drawer';
<div class="chat-sidenav__account">
<ng-content select="[sidenavAccount]" />
</div>
</aside>
</nav>
`,
})
export class ChatSidenavComponent {
Expand Down
4 changes: 2 additions & 2 deletions .../lib/primitives/chat-history-search-palette/chat-history-search-palette.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ describe('ChatHistorySearchPaletteComponent', () => {
it('Esc emits close', () => {
const fixture = render();
let emits = 0;
fixture.componentInstance.close.subscribe(() => emits++);
fixture.componentInstance.closed.subscribe(() => emits++);
const input = fixture.nativeElement.querySelector('input') as HTMLInputElement;
input.dispatchEvent(new KeyboardEvent('keydown', { key: 'Escape', bubbles: true }));
expect(emits).toBe(1);
Expand All @@ -123,7 +123,7 @@ describe('ChatHistorySearchPaletteComponent', () => {
it('Scrim click emits close', () => {
const fixture = render();
let emits = 0;
fixture.componentInstance.close.subscribe(() => emits++);
fixture.componentInstance.closed.subscribe(() => emits++);
const scrim = fixture.nativeElement.querySelector('.chat-history-search-palette__scrim') as HTMLButtonElement;
scrim.click();
expect(emits).toBe(1);
Expand Down
9 changes: 4 additions & 5 deletions ...t/src/lib/primitives/chat-history-search-palette/chat-history-search-palette.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ let paletteInstanceCounter = 0;
type="button"
class="chat-history-search-palette__scrim"
aria-label="Close search"
(click)="close.emit()"
(click)="closed.emit()"
></button>
<div
class="chat-history-search-palette"
Expand Down Expand Up @@ -64,7 +64,7 @@ let paletteInstanceCounter = 0;
type="button"
class="chat-history-search-palette__close"
aria-label="Close"
(click)="close.emit()"
(click)="closed.emit()"
>
<svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true">
<line x1="18" y1="6" x2="6" y2="18"/>
Expand Down Expand Up @@ -116,8 +116,7 @@ export class ChatHistorySearchPaletteComponent {
readonly placeholder = input<string>('Search conversations');

readonly threadSelected = output<string>();
// eslint-disable-next-line @angular-eslint/no-output-native
readonly close = output<void>();
readonly closed = output<void>();

protected readonly activeIndex = signal<number>(0);
protected readonly listId = `chat-history-search-palette__results-${++paletteInstanceCounter}`;
Expand Down Expand Up @@ -155,7 +154,7 @@ export class ChatHistorySearchPaletteComponent {
protected onInputKeydown(e: KeyboardEvent): void {
if (e.key === 'Escape') {
e.preventDefault();
this.close.emit();
this.closed.emit();
return;
}
if (e.key === 'ArrowDown') {
Expand Down
Loading