feat(chat): projects + Move-to-project (Phase 4)#273
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
d2c94ea to
464550f
Compare
Full Projects scope: Project type + ProjectActionAdapter; new chat-project-list primitive; chat-sidenav Projects section with "+ New project"; thread-project association via Thread.projectId?; "Move to project" thread row action via a second overflow-menu submenu. Example wires localStorage-backed ProjectsService. Defers per-project instructions / files / sharing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
14 tasks across type extensions, new chat-project-list primitive (styles + component + spec), chat-thread-list move-to-project submenu, chat-sidenav Projects section, ProjectsService (localStorage), ThreadsService projectId mapping, demo-shell wiring, API docs regen, and manual browser verification. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pin (Phase 3d, PR #267) landed first. Updates Task 6's chat-thread-list patches so "Move to project" inserts alongside existing pin/unpin entries instead of replacing them. Tasks 1, 7, 8, 10-13 remain valid. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ad list Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
464550f to
6d2254c
Compare
blove
added a commit
that referenced
this pull request
May 13, 2026
Three changes bundled per follow-up review notes: 1. examples/chat/smoke/CHECKLIST.md — adds 'Projects' and 'Move thread to project' sections covering PR #273 (Phase 4) end-to-end: inline create / rename / delete, filter behaviour, submenu wiring, idempotent moves, persistence across reload. 2. examples/chat/python/src/streaming/envelope_tool.py — Pydantic model_validator on A2uiEnvelope rejects envelopes with zero or multiple discriminators set. Catches LLM outputs that pass strict- mode validation but emit ambiguous shapes; two new tests cover the rejected cases. 3. examples/chat/angular/src/app/shell/threads.service.ts — fallback for threads without metadata.title changes from 'Thread 019e1e98...' (raw id slice) to a graceful 'Untitled'. Backend writes the title on the first user message; threads created via '+ New chat' and abandoned previously appeared with their raw id prefix in the sidenav.
blove
added a commit
that referenced
this pull request
May 13, 2026
Three changes bundled per follow-up review notes: 1. examples/chat/smoke/CHECKLIST.md — adds 'Projects' and 'Move thread to project' sections covering PR #273 (Phase 4) end-to-end: inline create / rename / delete, filter behaviour, submenu wiring, idempotent moves, persistence across reload. 2. examples/chat/python/src/streaming/envelope_tool.py — Pydantic model_validator on A2uiEnvelope rejects envelopes with zero or multiple discriminators set. Catches LLM outputs that pass strict- mode validation but emit ambiguous shapes; two new tests cover the rejected cases. 3. examples/chat/angular/src/app/shell/threads.service.ts — fallback for threads without metadata.title changes from 'Thread 019e1e98...' (raw id slice) to a graceful 'Untitled'. Backend writes the title on the first user message; threads created via '+ New chat' and abandoned previously appeared with their raw id prefix in the sidenav.
5 tasks
blove
added a commit
that referenced
this pull request
May 13, 2026
…278) Three changes bundled per follow-up review notes: 1. examples/chat/smoke/CHECKLIST.md — adds 'Projects' and 'Move thread to project' sections covering PR #273 (Phase 4) end-to-end: inline create / rename / delete, filter behaviour, submenu wiring, idempotent moves, persistence across reload. 2. examples/chat/python/src/streaming/envelope_tool.py — Pydantic model_validator on A2uiEnvelope rejects envelopes with zero or multiple discriminators set. Catches LLM outputs that pass strict- mode validation but emit ambiguous shapes; two new tests cover the rejected cases. 3. examples/chat/angular/src/app/shell/threads.service.ts — fallback for threads without metadata.title changes from 'Thread 019e1e98...' (raw id slice) to a graceful 'Untitled'. Backend writes the title on the first user message; threads created via '+ New chat' and abandoned previously appeared with their raw id prefix in the sidenav.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 4 introduces Projects as a first-class navigation surface in
@ngaf/chat. The sidenav gains a Projects section between the primary slot and Recent threads. Projects can be created (inline), renamed (inline), and deleted (with confirmation). Threads can be associated with a project at creation time AND moved between projects via a per-row submenu. Selecting a project filters the visible threads.Spec: docs/superpowers/specs/2026-05-12-chat-projects-design.md
Plan: docs/superpowers/plans/2026-05-12-chat-projects.md
New primitives
ChatProjectListComponent— sibling ofchat-thread-list. Inline "+ New project" → inline-create input. Hover-revealed kebab → Rename / Delete (destructive). Reuses existingchat-overflow-menu+chat-confirm-dialogprimitives. Optimistic rename + delete with rollback.Extended
Thread.projectId?: string | null— optional association field.ThreadActionAdapter.moveToProject?—(threadId, projectId | null) => Promise<void>. Optimistic-hide pattern on the current view.ChatThreadListComponent— newprojectsinput. NewmoveMenuOpenForIdsignal +moveMenuItemscomputed. Active-mode menu gains "Move to project" entry (between unpin and archive). Second<chat-overflow-menu>instance renders the move submenu (anchored to the same kebab) with items[No project, ...projects]. The submenu reuses the existing primitive.ChatSidenavComponent— three new inputs (projects,selectedProjectId,projectActions); two new outputs (projectSelected,newProjectRequested). Renders the Projects section between primary slot and Recent block. Forwardsprojectsto both innerchat-thread-listinstances.Public API additions
ChatProjectListComponentProjecttypeProjectActionAdaptertypeExample wiring (
examples-chat-angular)ProjectsService(new) — localStorage-backed. LangGraph has no native projects API; consumers with real backends bring their own adapter.ThreadsService—toThreadreadsmetadata.projectId;createaccepts optionalprojectId; newmoveToProjectmethod PATCHes thread metadata.demo-shell—selectedProjectIdsignal (persisted),visibleThreadscomputed filters by project,projectActionsadapter,threadActions.moveToProject, project handlers.Test plan
nx run chat:test— 583/583 pass (existing + 10 chat-project-list + 5 thread-list move-to-project + 4 sidenav projects = 19 new tests)nx run chat:build— cleannx lint chat— cleannx run examples-chat-angular:build— cleanOut of scope (deferred follow-ups)
🤖 Generated with Claude Code