fix(website): unbreak TS build (AnalyticsSurface + Button anchorAttrs)#274
Merged
Conversation
WhitePaperBlock.tsx passes 'home_whitepaper' as the surface property when tracking signup submissions, but the AnalyticsSurface union did not include that value — causing TS2322 build failures on main since the Statusbrew website refactor landed (#270). This is blocking unrelated PRs from merging because Website lint is a required check.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…Attrs
The 'rest as AnchorButtonProps' cast on line 115 contradicted the prior
destructure on line 106 that pulled 'href' out — TS then inferred that
anchorAttrs still had 'href', conflicting with the explicit href={href}
JSX prop. Result: TS2783 'href is specified more than once' build
failure since the Statusbrew website refactor (#270).
Removing the redundant cast lets TS infer anchorAttrs from the runtime-
true type (rest without href).
blove
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pre-existing TypeScript errors on main introduced by the Statusbrew website refactor (PR #270). Both blocked the required `Website — lint / build` check on every unrelated PR.
Test plan