fix(chat-sidebar): position launcher at bottom-right via fixed wrapper#310
Merged
Conversation
The previous fix (#308) added <chat-launcher-button> to the chat-sidebar template, but the launcher itself has no inherent fixed positioning (it's a 56×56 div with `display: inline-block`). chat-popup positions its launcher via :host { position: fixed }, but chat-sidebar's :host is `display: block` to allow the content-pushes-on-open behavior. So the newly-added launcher in chat-sidebar flowed into the document at the natural position of the component — which for the demo shell ends up at (280, 1972), well off-screen. Wrap the launcher in a .chat-sidebar__launcher div with position: fixed; bottom: 1rem; right: 1rem; z-index: 30; matching chat-popup's launcher coordinates exactly. Also hide the launcher when the sidebar is open (the panel covers it and the panel has its own close button). Verified via demo.cacheplane.ai browser smoke after the previous fix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #308. The previous fix added `` to the chat-sidebar template, but the launcher itself has no inherent fixed positioning — it's a 56×56 div with `display: inline-block`. chat-popup positions its launcher via `:host { position: fixed }`, but chat-sidebar's `:host` is `display: block` to allow the content-pushes-on-open behavior.
The newly-added launcher in chat-sidebar flowed into the document at the natural position of the component — which on demo.cacheplane.ai ended up at (280, 1972), well off-screen.
Fix
Wrap the launcher in a `.chat-sidebar__launcher` div with:
```css
position: fixed;
bottom: 1rem;
right: 1rem;
z-index: 30;
```
Matches chat-popup's launcher coordinates exactly. Also hides the launcher when the sidebar is open (the panel covers it; the panel has its own close button).
Test plan
🤖 Generated with Claude Code