test(examples-chat): A2UI single-bubble invariant — Phase 2c#322
Merged
Conversation
Drives an A2UI v1 GenUI prompt through the harness via a mock tool-call response carrying envelopes as args. Asserts exactly one assistant bubble per turn (PR #297 single-bubble invariant) and the absence of standalone skeleton bubbles. Progressive mount (chunked tool-call args) deferred to Phase 2d. Task 0 de-risks the mock + langgraph tool-call handoff before any committed code lands.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an end-to-end Playwright scenario that drives an A2UI v1 GenUI prompt through the harness and asserts the single-bubble invariant from #297 — exactly one assistant
<chat-message>per GenUI turn, with<a2ui-surface>rendered inside it. No standalone<chat-genui-skeleton>residue.The fixture is a real captured tool-call response from
gpt-4o-minifor the "Demo: render a feedback form" prompt (Column + 5 form components). Mid-implementation the handwritten fixture failed because envelope schemas didn't validate against the python graph's strict pydantic types; switching to a real captured response sidestepped the guessing.Sits on Phase 2b (#314).
Test plan
playwright.config.ts)Notes for reviewers
toBeAttachedis used in place oftoBeVisibleon the<a2ui-surface>locator — the bubble container has zero computed size during progressive mount and Playwright's strict visibility check flags that even when the surface is rendering correctly. The follow-upexpect.poll(...).toBeGreaterThan(0)overa2ui-columncount is the actual "rendered" check.ab3c41eb) and the original handwritten fixture commit (5a0ad825) are kept in history rather than squashed — the second fixture commit (61b2692b) replaces the content with the real capture and tells the story.