feat(example-layouts): PR-0 auto-install side effect + pilot cleanup#338
Merged
Conversation
Completes the rollout of cockpit-example theme sync to the remaining 31 Angular example apps. Five-PR sequence: PR-0 (library auto-install + pilot cleanup), PR-1 (chat wave, 10 apps incl. a2ui migration to example-chat-layout), PR-2 (langgraph, 8 apps), PR-3 (deep-agents, 6 apps), PR-4 (render + ag-ui, 7 apps). Key decisions: - installEmbeddedTheme moves to module-level side effect in @ngaf/example-layouts; main.ts files stay clean - Templates use --ngaf-chat-* (chat lib namespace), not --ds-* - A2UI wrapped in <example-chat-layout> for structural consistency - Manual chrome MCP smoke per app per wave Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The auto-install side effect added in this PR runs at module load in public-api.ts. With `sideEffects: false`, bundlers (esbuild/webpack/ rollup) are free to drop the module-level statement when only the named exports are consumed — tree-shaking would silently break the auto-install in production builds. Switch to an array form listing public-api.ts as the only file with side effects. Layout components and the installEmbeddedTheme function are still tree-shake-safe individually. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR-0 of Stage 2 (spec: `docs/superpowers/specs/2026-05-15-examples-theme-sync-stage-2-design.md`, plan: `docs/superpowers/plans/2026-05-15-examples-theme-sync-stage-2-pr-0.md`).
After this PR lands, wave PRs (PR-1 chat, PR-2 langgraph, PR-3 deep-agents, PR-4 render+ag-ui) migrate the remaining 31 apps following the same clean pattern (no explicit `installEmbeddedTheme` in any app's `main.ts`).
Test plan
🤖 Generated with Claude Code