fix(website): fix flaky e2e test blocking production deploys#38
Merged
Conversation
…ct subpath
Production Angular examples at examples.stream-resource.dev returned 404 for
main.js, styles.css, and chunks. Root cause: all index.html files had
<base href="/"> so asset URLs resolved to the domain root instead of
/{product}/{topic}/. Fix: assemble script now rewrites base href to the
correct subpath for each example.
blove
added a commit
that referenced
this pull request
Apr 7, 2026
* fix(deploy): rewrite base href per example so assets resolve to correct subpath
Production Angular examples at examples.stream-resource.dev returned 404 for
main.js, styles.css, and chunks. Root cause: all index.html files had
<base href="/"> so asset URLs resolved to the domain root instead of
/{product}/{topic}/. Fix: assemble script now rewrites base href to the
correct subpath for each example.
* fix(website): use .first() on form locator to handle multiple forms on pricing page
blove
added a commit
that referenced
this pull request
Apr 7, 2026
* fix(deploy): rewrite base href per example so assets resolve to correct subpath
Production Angular examples at examples.stream-resource.dev returned 404 for
main.js, styles.css, and chunks. Root cause: all index.html files had
<base href="/"> so asset URLs resolved to the domain root instead of
/{product}/{topic}/. Fix: assemble script now rewrites base href to the
correct subpath for each example.
* fix(website): use .first() on form locator to handle multiple forms on pricing page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pricing page e2e test fails in strict mode because
page.locator('form')resolves to 2 elements (lead form + newsletter form). This blocks the Vercel deploy step, preventing all production updates.Fix: use
.first()to target the primary lead form.This also unblocks the base-href deploy fix from PR #37 which merged but couldn't deploy.
Test plan
locator('form') resolved to 2 elements