[codex] add required CI gate#519
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI — requiredpull-request gate that waits for every scoped CI job and fails if any selected job fails, is cancelled, or is skipped unexpectedly.ci-scopeoutputs while preserving the existingCockpit — e2echeck name.Root Cause
Branch protection only required
Vercel – threadplane, so GitHub auto-merge could merge a PR while GitHub Actions jobs were still running or while non-required CI jobs were failing. GitHub auto-merge waits for required status checks, not every check in a workflow.Branch Protection
mainbranch protection has already been updated to require:Vercel – threadplaneCI — requiredStrict required status checks are enabled.
Test Plan
node --test scripts/ci-workflow.spec.mjsnode --test scripts/ci-scope.spec.mjs.github/workflows/ci.ymlgit diff --check