test(examples-chat): pin no-nav-loop invariant#541
Merged
Conversation
Adds a regression guard for the invariant every PR in the routing chain (#500/#504/#514/#518/#527) was dancing around: when the URL→ signal effect hydrates threadIdSignal from /embed/<id>, the signal→URL effect MUST see signal === urlState().threadId and short-circuit. Without that guard we'd loop: URL → signal → router.navigate → URL → ... The test asserts zero NavigationEnd events fire between the initial navigateByUrl and the end of detectChanges — proving the compare- and-set guard at demo-shell.component.ts (signal→URL effect) does its job. 33/33 examples-chat-angular unit tests passing locally.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression guard for the URL↔signal sync invariant that every PR in the routing chain (#500/#504/#514/#518/#527) was dancing around: when the URL→signal effect hydrates
threadIdSignalfrom/embed/<id>, the signal→URL effect MUST see signal===urlId and short-circuit. Without the guard we'd loop:The test asserts zero NavigationEnd events fire between initial
navigateByUrland end ofdetectChanges— proving the compare-and-set guard atdemo-shell.component.ts(signal→URL effect) does its job.Follow-up: Minting service Vercel deploy
Unrelated to this PR but worth flagging: the
Minting service deployjob has been red on the last 4 main runs. Error:The Vercel project for minting-service has its Root Directory set to
apps/minting-servicein the Vercel dashboard. The workflow runsvercel pullfromworking-directory: apps/minting-service, so Vercel computes the root as<cwd>/<configured-root>and the path doubles.Fix (Vercel dashboard, no code change required): set the project's Root Directory to empty/blank.
Test plan
🤖 Generated with Claude Code