fix(website): hamburger leaking onto desktop nav#560
Merged
Conversation
…nter
The mobile hamburger had `className="lg:hidden"` but also an inline
`style={{ display: 'inline-flex' }}` (added with the 44x44 hit-area
expansion). Inline styles beat class utilities, so `lg:hidden` could
never set display:none — the hamburger rendered at every width. With
three children in the `justify-between` top bar (logo | links |
hamburger), the links got parked in the center instead of hard-right.
Move display + centering into the class list (`inline-flex items-center
justify-center`) so `lg:hidden` wins at >=lg. Hit area (padding/margin)
stays inline. Verified: hamburger is display:none at desktop, visible
below lg.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a navbar regression where the mobile hamburger showed at desktop width and pushed the nav links to the center.
Root cause: the hamburger button had
className="lg:hidden"(should bedisplay:noneat ≥1024px) but also an inlinestyle={{ display: 'inline-flex' }}— added alongside the 44×44 hit-area expansion in the recent mobile-hygiene work. Inline styles beat class utilities, solg:hiddenwas powerless and the hamburger rendered at every width. The top bar isflex justify-between; with three children (logo | links | hamburger) the links got parked center instead of hard-right.Fix: move display + centering into the class list (
inline-flex items-center justify-center) solg:hiddenwins at ≥lg. The hit-area padding/margin stays inline (no conflict).Verification (Chrome MCP)
computed display: none, desktop links visible and right-aligned. Confirmed via screenshot.displayremoved (btn.style.displayis unset); display now governed by thelg:hidden/inline-flexutilities.inline-flexkeeps the hamburger visible + centered (unchanged behavior).Test plan