feat(bench): interaction-window slicing for CDP traces + correction to PR #145#146
Merged
Conversation
…o PR #145 Adds three performance.mark calls to bench-runtime (interaction.start, .firstFrame, .settled) and `blink.user_timing` to the CDP categories list, so traces include the interaction window bounds. Extends scripts/analyze-cdp.mjs with --window=interaction|settle|full; default remains full for backwards compat. Findings: with interaction-window slicing, the leading hotspot for filter-text / S2 / hypothesis is `matchesFilters` (packages/grid-core/src/derived-rows.ts:73) at ~800μs / 15% of the 6.97 ms interaction window. PR #145's `getEstimatedRowHeightSignature` hypothesis was a full-trace artifact dominated by initial-mount work (3000-row cache fill). Correction memo at docs/research/2026-05-16-bench-cdp-window-slicing-correction.md queues the lowercase-cache fix as a clean follow-up. No production code change. Quality wedge untouched. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Vercel preview readyPreview: https://pretable-d7v8igkli-cacheplane.vercel.app Updated automatically by the |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What the sliced trace shows (n=1)
The real interaction-window hotspot is `matchesFilters` (`packages/grid-core/src/derived-rows.ts:73`) — lowercasing every cell value on every filter call across all 3000 source rows. ~800μs of the 6.97 ms window.
What's NOT in this PR
Lesson saved to memory
"Always slice CDP traces to the interaction window before naming a hotspot — full-trace view is dominated by mount-time work that doesn't count against `interaction_latency_ms`."
Gates
🤖 Generated with Claude Code