docs(ui): correct data-attribute hook names in README#161
Merged
Conversation
The "Data-attribute hooks" section listed `[data-pretable-cell-focused]` and `[data-pretable-cell-selected]`, which do not exist in the rendered DOM. Per grid.css the real hooks are value-attributes on the cell: `[data-pretable-cell][data-focused="true"]` and `[data-selected="true"]`, plus `[data-pinned="left"|"right"]` and `[data-pretable-numeric="true"]`. Align the README so consumers targeting them with CSS aren't misled. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Vercel preview readyPreview: https://pretable-9l9xfk831-cacheplane.vercel.app Updated automatically by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Data-attribute hooks section of
packages/ui/README.mdlisted two attributes that do not exist in the rendered grid DOM:[data-pretable-cell-focused][data-pretable-cell-selected]Why
Per
packages/ui/src/grid.css, focus/selection are expressed as value-attributes on the cell, not standalone attributes:Consumers copying the README names into their own CSS would target selectors that never match.
Change
Replaced the incorrect names with the real hooks, and added the other cell value-attributes documented in
grid.cssfor completeness:[data-pretable-cell][data-focused="true"][data-pretable-cell][data-selected="true"][data-pretable-cell][data-pinned="left"|"right"][data-pretable-cell][data-pretable-numeric="true"]Docs-only, no code change.
🤖 Generated with Claude Code