chore(deps): bump bench comparators to AG Grid 35 + MUI X 8#162
Merged
Conversation
Bumps the comparator dependencies in apps/bench to their latest majors, superseding dependabot PRs #149/#152 (ag-grid 33->35) and #150 (@mui/x-data-grid 7->8): - ag-grid-community / ag-grid-react: ^33.3.2 -> ^35.3.0 (resolves 35.3.1) - @mui/x-data-grid: ^7.29.13 -> ^8.28.6 (resolves 8.29.0) No adapter code changes were required. The AG Grid (setFilterModel / applyColumnState) and MUI (setFilterModel / setSortModel / filteredRowsSet selector) APIs the bench drives are unchanged across these majors, and typecheck/lint/unit tests pass clean. Verified in real Chromium via `pnpm bench:matrix --adapters=pretable,ag-grid,mui --scenarios=S2 --scripts=scroll,sort,filter-metadata,filter-text --scale=hypothesis --repeats=2` (24 runs, all completed): | adapter | filter-metadata | filter-text | sort | scroll | | -------- | --------------- | ----------- | --------- | ------ | | ag-grid | rows=750 | rows=500 | rows=3000 | ok | | mui | rows=750 | rows=500 | rows=3000 | ok | | pretable | rows=750 | rows=500 | rows=3000 | ok | Post-filter row counts (750/500) and sort (no filter -> 3000) match pretable, confirming the comparators still filter/sort correctly on the new majors. Note: @mui/x-data-grid@8 peer-requests @mui/material ^5||^6||^7, but the repo is on @mui/material@9. This peer mismatch is pre-existing (x-data-grid@7 already peer-wanted material ^5||^6 against material@9) and works at runtime, as the matrix above confirms. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Vercel preview readyPreview: https://pretable-9svqnbus5-cacheplane.vercel.app Updated automatically by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the benchmark comparator dependencies in
apps/benchto their latest majors, superseding dependabot PRs #149 / #152 (ag-grid 33→35) and #150 (@mui/x-data-grid7→8).What changed
ag-grid-community/ag-grid-react:^33.3.2→^35.3.0(resolves 35.3.1)@mui/x-data-grid:^7.29.13→^8.28.6(resolves 8.29.0)No adapter code changes were required. The AG Grid (
setFilterModel/applyColumnState) and MUI (setFilterModel/setSortModel/filteredRowsSetselector) APIs the bench drives are unchanged across these majors.Verification
Gates:
typecheck✓,lint✓,vitest✓ (62/62, incl. the AG Grid filter regression test).Real-Chromium matrix —
pnpm bench:matrix --adapters=pretable,ag-grid,mui --scenarios=S2 --scripts=scroll,sort,filter-metadata,filter-text --scale=hypothesis --repeats=2(24 runs, allcompleted):rows=750rows=500rows=3000rows=750rows=500rows=3000rows=750rows=500rows=3000Post-filter row counts (750/500) and sort (no filter → 3000) match pretable, confirming the comparators still filter/sort correctly on the new majors. Latencies are consistent with the prior baselines (ag-grid ~50ms, mui ~33ms, pretable ~16ms filter).
Peer-dependency note
@mui/x-data-grid@8peer-requests@mui/material ^5||^6||^7, but the repo is on@mui/material@9(currentlatest). This peer mismatch is pre-existing —x-data-grid@7already peer-wantedmaterial ^5||^6againstmaterial@9— and works at runtime, as the matrix above confirms. MUI X has not yet shipped a release that declaresmaterial@9support.Follow-up
Once this merges, dependabot PRs #149, #152, and #150 can be closed as superseded.
🤖 Generated with Claude Code