Skip to content

Conversation

@jbrooksuk
Copy link
Member

I think this is right? It's untested.

DB_DRIVER=${DB_DRIVER:-mysql}
DB_HOST=${DB_HOST:-mysql}
DB_DRIVER=${DB_DRIVER:-pgsql}
DB_HOST=${DB_HOST:-127.0.0.1}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should default to postgres rather than 127.0.0.1 as we have name the postgres container and setup a Docjer link to the Cachet container in https://github.com/CachetHQ/Docker/blob/master/docker-compose.yml#L16

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@djdefi djdefi merged commit ce53cd7 into master May 25, 2016
@jbrooksuk jbrooksuk deleted the jbrooksuk-patch-1 branch May 25, 2016 17:22
djdefi added a commit that referenced this pull request May 27, 2016
* Use PgSQL default

* change DB_HOST default
djdefi added a commit that referenced this pull request May 27, 2016
* Use PgSQL default

* change DB_HOST default
djdefi added a commit that referenced this pull request May 27, 2016
* Use PgSQL default (#78) (#79)

* Use PgSQL default

* change DB_HOST default

* Image enhancements and best practices

* Set to master version

* enable cachet_ver ARG for build time version override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants