Lowercase email for Gravatar avatars#3712
Merged
jbrooksuk merged 1 commit intocachethq:2.3from Aug 14, 2019
Merged
Conversation
The Gravatar docs explicitly say that e-mail addresses have to be lowercased before hashing. In the `2.4` branch this was already resolved in `0f4c14ac0820562a3155d6f60ea4a7770d19084b` back in 2016 so it is safe to backport that change to the latest stable branch for a maintenance patch release.
|
Congratulations on opening your first Pull Request, this is a momentous day for you and us! ✨
|
Author
|
Bug ref: #2123 |
|
Hooray! Your first Pull Request was merged, here's to many more 🚀 |
Member
|
I'll sort a v2.3 release at some point :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gravatar docs explicitly say that e-mail addresses have to be lowercased before hashing. In the
2.4branch this was already resolved in 0f4c14a back in 2016 so it is safe to backport that change to the latest stable branch for a maintenance patch release.