Add realm to Proxy-Authenticate header#53
Merged
sergeyfrolov merged 2 commits intomasterfrom Feb 4, 2019
Merged
Conversation
Resolves #52 Squid's default realm is "Squid proxy-caching web server", so I decided to give descriptive realm to Caddy as well.
sergeyfrolov
added a commit
that referenced
this pull request
May 29, 2019
In #53 we added a realm to the Proxy-Authenticate header, but the realm only is added, when `probe_resistance` is off. Proxy-Authenticate header should have a realm when `probe_resistance` is on as well.
4 tasks
sergeyfrolov
added a commit
that referenced
this pull request
May 29, 2019
In #53 we added a realm to the Proxy-Authenticate header, but the realm only is added, when `probe_resistance` is off. With this change, Proxy-Authenticate header will have a realm when `probe_resistance` is on as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. What does this change do, exactly?
Even though realm was not required in older standards, newer https://tools.ietf.org/html/rfc7617 says
I can't seem to find any functional meaning behind realms in this context. Squid's default realm is "Squid proxy-caching web server", so I gave descriptive realm to Caddy as well: "Caddy Secure Web Proxy".
Proxy-Authenticate: Basic->Proxy-Authenticate: Basic realm="Caddy Secure Web Proxy"2. Please link to the relevant issues.
Resolves #52
3. Which documentation changes (if any) need to be made because of this PR?
None
4. Checklist
localhost:1234for testing. cc @mholt