Make Proto Mappers Unopinionated #1038
Merged
+415
−223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
shijiesheng and
taylanisikdemir
as code owners
shijiesheng
approved these changes
Nov 18, 2025
Proto objects throw a NullPointerException if you pass a null value into any setFoo method. Our current mappers make strong assumptions about what fields are and aren't necessary, and any time they don't match either the server or the client logic we get a vague NullPointerException. Instead, map all objects and don't assume that any field is non-null. The server or client should enforce the validity of the requests rather than the mapper. Additionally don't mutate Maps that we receive from Thrift/Proto in WorkflowContext.
natemort
force-pushed
the
proto_mappers
branch
from
a21b03d to
6759f1d
Compare
timl3136
reviewed
Nov 18, 2025
| .setWorkflowExecution(TypeMapper.workflowRunPair(t.getWorkflowID(), t.getRunID())) | ||
| .setActivityId(t.getActivityID()) | ||
| .setDetails(payload(t.getDetails())); | ||
| .setWorkflowExecution(TypeMapper.workflowRunPair(t.getWorkflowID(), t.getRunID())); |
Member
There was a problem hiding this comment.
do we need nil check for wfID and runID?
Member
Author
There was a problem hiding this comment.
Those are handled within the workflowRunPair method. If they're null the field in the WorkflowExecution will be empty.
timl3136
requested changes
Nov 18, 2025
Member
timl3136
left a comment
timl3136
left a comment
There was a problem hiding this comment.
left a quick question regarding the nil check ^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto objects throw a NullPointerException if you pass a null value into any setFoo method. Our current mappers make strong assumptions about what fields are and aren't necessary, and any time they don't match either the server or the client logic we get a vague NullPointerException.
Instead, map all objects and don't assume that any field is non-null. The server or client should enforce the validity of the requests rather than the mapper.
Additionally don't mutate Maps that we receive from Thrift/Proto in WorkflowContext.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes