Skip to content

Make Proto Mappers Unopinionated #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
+415 −223
Merged

Make Proto Mappers Unopinionated #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 44 additions & 17 deletions src/main/java/com/uber/cadence/internal/compatibility/proto/DecisionMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ static Decision decision(com.uber.cadence.Decision d) {
d.getScheduleActivityTaskDecisionAttributes();
ScheduleActivityTaskDecisionAttributes.Builder builder =
ScheduleActivityTaskDecisionAttributes.newBuilder()
.setActivityId(attr.getActivityId())
.setActivityType(activityType(attr.getActivityType()))
.setTaskList(taskList(attr.getTaskList()))
.setInput(payload(attr.getInput()))
Expand All @@ -89,6 +88,9 @@ static Decision decision(com.uber.cadence.Decision d) {
.setHeartbeatTimeout(secondsToDuration(attr.getHeartbeatTimeoutSeconds()))
.setHeader(header(attr.getHeader()))
.setRequestLocalDispatch(attr.isRequestLocalDispatch());
if (attr.getActivityId() != null) {
builder.setActivityId(attr.getActivityId());
}
if (attr.getRetryPolicy() != null) {
builder.setRetryPolicy(retryPolicy(attr.getRetryPolicy()));
}
Expand All @@ -102,19 +104,27 @@ static Decision decision(com.uber.cadence.Decision d) {
{
com.uber.cadence.RequestCancelActivityTaskDecisionAttributes attr =
d.getRequestCancelActivityTaskDecisionAttributes();
decision.setRequestCancelActivityTaskDecisionAttributes(
RequestCancelActivityTaskDecisionAttributes.newBuilder()
.setActivityId(attr.getActivityId()));

RequestCancelActivityTaskDecisionAttributes.Builder builder =
RequestCancelActivityTaskDecisionAttributes.newBuilder();
if (attr.getActivityId() != null) {
builder.setActivityId(attr.getActivityId());
}
decision.setRequestCancelActivityTaskDecisionAttributes(builder.build());
}
break;
case StartTimer:
{
com.uber.cadence.StartTimerDecisionAttributes attr = d.getStartTimerDecisionAttributes();
decision.setStartTimerDecisionAttributes(
StartTimerDecisionAttributes.Builder builder =
StartTimerDecisionAttributes.newBuilder()
.setTimerId(attr.getTimerId())
.setStartToFireTimeout(
secondsToDuration(longToInt(attr.getStartToFireTimeoutSeconds()))));
secondsToDuration(longToInt(attr.getStartToFireTimeoutSeconds())));
if (attr.getTimerId() != null) {
builder.setTimerId(attr.getTimerId());
}

decision.setStartTimerDecisionAttributes(builder.build());
}
break;
case CompleteWorkflowExecution:
Expand All @@ -139,8 +149,12 @@ static Decision decision(com.uber.cadence.Decision d) {
{
com.uber.cadence.CancelTimerDecisionAttributes attr =
d.getCancelTimerDecisionAttributes();
decision.setCancelTimerDecisionAttributes(
CancelTimerDecisionAttributes.newBuilder().setTimerId(attr.getTimerId()));
CancelTimerDecisionAttributes.Builder builder =
CancelTimerDecisionAttributes.newBuilder();
if (attr.getTimerId() != null) {
builder.setTimerId(attr.getTimerId());
}
decision.setCancelTimerDecisionAttributes(builder.build());
}
break;
case CancelWorkflowExecution:
Expand All @@ -158,9 +172,11 @@ static Decision decision(com.uber.cadence.Decision d) {
d.getRequestCancelExternalWorkflowExecutionDecisionAttributes();
RequestCancelExternalWorkflowExecutionDecisionAttributes.Builder builder =
RequestCancelExternalWorkflowExecutionDecisionAttributes.newBuilder()
.setDomain(attr.getDomain())
.setWorkflowExecution(workflowRunPair(attr.getWorkflowId(), attr.getRunId()))
.setChildWorkflowOnly(attr.isChildWorkflowOnly());
if (attr.getDomain() != null) {
builder.setDomain(attr.getDomain());
}
if (attr.getControl() != null) {
builder.setControl(arrayToByteString(attr.getControl()));
}
Expand Down Expand Up @@ -203,8 +219,6 @@ static Decision decision(com.uber.cadence.Decision d) {
d.getStartChildWorkflowExecutionDecisionAttributes();
StartChildWorkflowExecutionDecisionAttributes.Builder builder =
StartChildWorkflowExecutionDecisionAttributes.newBuilder()
.setDomain(attr.getDomain())
.setWorkflowId(attr.getWorkflowId())
.setWorkflowType(workflowType(attr.getWorkflowType()))
.setTaskList(taskList(attr.getTaskList()))
.setInput(payload(attr.getInput()))
Expand All @@ -217,6 +231,12 @@ static Decision decision(com.uber.cadence.Decision d) {
.setHeader(header(attr.getHeader()))
.setMemo(memo(attr.getMemo()))
.setSearchAttributes(searchAttributes(attr.getSearchAttributes()));
if (attr.getDomain() != null) {
builder.setDomain(attr.getDomain());
}
if (attr.getWorkflowId() != null) {
builder.setWorkflowId(attr.getWorkflowId());
}
if (attr.getRetryPolicy() != null) {
builder.setRetryPolicy(retryPolicy(attr.getRetryPolicy()));
}
Expand All @@ -235,11 +255,15 @@ static Decision decision(com.uber.cadence.Decision d) {
d.getSignalExternalWorkflowExecutionDecisionAttributes();
SignalExternalWorkflowExecutionDecisionAttributes.Builder builder =
SignalExternalWorkflowExecutionDecisionAttributes.newBuilder()
.setDomain(attr.getDomain())
.setWorkflowExecution(workflowExecution(attr.getExecution()))
.setSignalName(attr.getSignalName())
.setInput(payload(attr.getInput()))
.setChildWorkflowOnly(attr.isChildWorkflowOnly());
if (attr.getDomain() != null) {
builder.setDomain(attr.getDomain());
}
if (attr.getSignalName() != null) {
builder.setSignalName(attr.getSignalName());
}
if (attr.getControl() != null) {
builder.setControl(arrayToByteString(attr.getControl()));
}
Expand All @@ -259,11 +283,14 @@ static Decision decision(com.uber.cadence.Decision d) {
{
com.uber.cadence.RecordMarkerDecisionAttributes attr =
d.getRecordMarkerDecisionAttributes();
decision.setRecordMarkerDecisionAttributes(
RecordMarkerDecisionAttributes.Builder builder =
RecordMarkerDecisionAttributes.newBuilder()
.setMarkerName(attr.getMarkerName())
.setDetails(payload(attr.getDetails()))
.setHeader(header(attr.getHeader())));
.setHeader(header(attr.getHeader()));
if (attr.getMarkerName() != null) {
builder.setMarkerName(attr.getMarkerName());
}
decision.setRecordMarkerDecisionAttributes(builder.build());
}
break;
default:
Expand Down
Loading