Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cadence/_internal/activity/_activity_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ async def _report_failure(
_logger.exception("Exception reporting activity failure")

async def _report_success(self, task: PollForActivityTaskResponse, result: Any):
as_payload = await self._data_converter.to_data([result])
as_payload = self._data_converter.to_data([result])

try:
await self._client.worker_stub.RespondActivityTaskCompleted(
Expand Down
8 changes: 4 additions & 4 deletions cadence/_internal/activity/_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ def __init__(
self._activity_fn = activity_fn

async def execute(self, payload: Payload) -> Any:
params = await self._to_params(payload)
params = self._to_params(payload)
with self._activate():
return await self._activity_fn(*params)

async def _to_params(self, payload: Payload) -> list[Any]:
def _to_params(self, payload: Payload) -> list[Any]:
type_hints = [param.type_hint for param in self._activity_fn.params]
return await self._client.data_converter.from_data(payload, type_hints)
return self._client.data_converter.from_data(payload, type_hints)

def client(self) -> Client:
return self._client
Expand All @@ -46,7 +46,7 @@ def __init__(
self._executor = executor

async def execute(self, payload: Payload) -> Any:
params = await self._to_params(payload)
params = self._to_params(payload)
loop = asyncio.get_running_loop()
return await loop.run_in_executor(self._executor, self._run, params)

Expand Down
Loading