Feature/notification bar #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gger notification bar from any subview.
…r handling logic.
ksnyder9801
approved these changes
Feb 18, 2020
ksnyder9801
approved these changes
Feb 27, 2020
adriannesoike
approved these changes
Feb 27, 2020
This was
linked to
issues
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding global notification bar which can be triggered by eventing 'onNotification' event with a message and type. The global notification bar will disappear after 5 seconds, or when a user presses the X button.
Hooked up terminate button on summary view to trigger this when the API returns an error or is successful.
In future PRs I will change currently handled errors to follow this pattern.
Screenshot
Terminating workflow successfully
Error terminating workflow
Timeout error on history page
This particular use case addresses issue: #40