Add dead end filtration #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
|
Before merging, please clean up the commit history a bit. If you want, I can also do it. |
daklauss
force-pushed
the
add-dead-end-filtration
branch
from
7061aaf to
4c855d9
Compare
Member
Author
done |
Added residual and testfiles Removed false risidual, + cstr residual v<0 => error Seperated error testing in another class Throw not implemented error @Viscosity Notinitialized Error now inherits from CADETPython SimulatorError
happening adding a pipeline.yml for testing with pytest on push adding ruff.yml wip addded a ruff workflow added python 3.12 to the pipeline to check when sundials and numpy are working
daklauss
force-pushed
the
add-dead-end-filtration
branch
from
4c855d9 to
dd31d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7