This repository was archived by the owner on Mar 8, 2024. It is now read-only.
Decrease visibility of classes in Jimple EvoSuite package#184
Merged
gandreadis merged 2 commits intomasterfrom May 31, 2018
Merged
Decrease visibility of classes in Jimple EvoSuite package#184gandreadis merged 2 commits intomasterfrom
gandreadis merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
============================================
+ Coverage 82.26% 82.42% +0.16%
- Complexity 316 353 +37
============================================
Files 39 41 +2
Lines 733 774 +41
Branches 153 163 +10
============================================
+ Hits 603 638 +35
- Misses 59 60 +1
- Partials 71 76 +5
Continue to review full report at Codecov.
|
fwdekker
suggested changes
May 31, 2018
Member
fwdekker
left a comment
There was a problem hiding this comment.
The exception classes should be private
Contributor
Author
|
@fwdekker Yes but they are used in the tests, so they need be internal. But I do agree, usually they should be private. In general I quite dislike that methods often can't be private for testing purposes. I know that tests should ideally only test the interface of a class, but still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classes that do not implement the interface should not be public. Therefore, these have been made internal. Their functions have also been made internal, and some have been made private.
The
ValueIsNotLocalExceptionhas been made internal as this should also not be part of the interface, it is only thrown.