Skip to content
This repository was archived by the owner on Mar 8, 2024. It is now read-only.

Decrease visibility of classes in Jimple EvoSuite package#184

Merged
gandreadis merged 2 commits intomasterfrom
testgenerator-jimpleevosuite-visibility
May 31, 2018
Merged

Decrease visibility of classes in Jimple EvoSuite package#184
gandreadis merged 2 commits intomasterfrom
testgenerator-jimpleevosuite-visibility

Conversation

@JSAbrahams
Copy link
Copy Markdown
Contributor

@JSAbrahams JSAbrahams commented May 31, 2018

Classes that do not implement the interface should not be public. Therefore, these have been made internal. Their functions have also been made internal, and some have been made private.

The ValueIsNotLocalException has been made internal as this should also not be part of the interface, it is only thrown.

@JSAbrahams JSAbrahams added the code quality Code quality improvements label May 31, 2018
Copy link
Copy Markdown
Member

@gandreadis gandreadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #184 into master will increase coverage by 0.16%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #184      +/-   ##
============================================
+ Coverage     82.26%   82.42%   +0.16%     
- Complexity      316      353      +37     
============================================
  Files            39       41       +2     
  Lines           733      774      +41     
  Branches        153      163      +10     
============================================
+ Hits            603      638      +35     
- Misses           59       60       +1     
- Partials         71       76       +5
Impacted Files Coverage Δ Complexity Δ
...peline/testgenerator/jimpleevosuite/ClassWriter.kt 100% <100%> (ø) 4 <1> (ø) ⬇️
...tgenerator/jimpleevosuite/EvosuiteTestGenerator.kt 79.31% <100%> (ø) 0 <0> (ø) ⬇️
...ine/testgenerator/jimpleevosuite/ClassGenerator.kt 89.13% <50%> (ø) 25 <1> (ø) ⬇️
...n/src/main/kotlin/org/cafejojo/schaapi/Pipeline.kt 100% <0%> (ø) 4% <0%> (+1%) ⬆️
...i/pipeline/patterndetector/spam/PatternDetector.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...line/patterndetector/prefixspan/PatternDetector.kt 100% <0%> (ø) 3% <0%> (ø) ⬇️
...tterndetector/prefixspan/FrequentSequenceFinder.kt 90% <0%> (ø) 23% <0%> (?)
...ine/patterndetector/spam/FrequentSequenceFinder.kt 83.33% <0%> (ø) 13% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc351b6...74f461d. Read the comment docs.

Copy link
Copy Markdown
Member

@fwdekker fwdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception classes should be private

@fwdekker fwdekker changed the title Decrease visibility of Classes in Jimple EvoSuite Package Decrease visibility of classes in Jimple EvoSuite package May 31, 2018
@JSAbrahams
Copy link
Copy Markdown
Contributor Author

JSAbrahams commented May 31, 2018

@fwdekker Yes but they are used in the tests, so they need be internal. But I do agree, usually they should be private. In general I quite dislike that methods often can't be private for testing purposes. I know that tests should ideally only test the interface of a class, but still.

Copy link
Copy Markdown
Member

@fwdekker fwdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, alright then.

@gandreadis gandreadis merged commit 723f3f8 into master May 31, 2018
@gandreadis gandreadis deleted the testgenerator-jimpleevosuite-visibility branch May 31, 2018 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

code quality Code quality improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants