Skip to content
This repository was archived by the owner on Mar 8, 2024. It is now read-only.

Make All Tests Internal Objects#193

Merged
fwdekker merged 8 commits intomasterfrom
test-visibility
Jun 1, 2018
Merged

Make All Tests Internal Objects#193
fwdekker merged 8 commits intomasterfrom
test-visibility

Conversation

@JSAbrahams
Copy link
Copy Markdown
Contributor

This was done:

  • To decrease visibility of tests. They should not be visible outside the module
  • There is no need for mutiple instances of tests, so they are all objects. This also follows the Spek recommendations.

@JSAbrahams JSAbrahams added the code quality Code quality improvements label Jun 1, 2018
@JSAbrahams JSAbrahams changed the title Make all unit tests internal objects Make all Tests Internal Objects Jun 1, 2018
@JSAbrahams JSAbrahams changed the title Make all Tests Internal Objects Make All Tests Internal Objects Jun 1, 2018
Copy link
Copy Markdown
Member

@gandreadis gandreadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #193 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #193   +/-   ##
=========================================
  Coverage     82.05%   82.05%           
  Complexity      317      317           
=========================================
  Files            39       39           
  Lines           741      741           
  Branches        155      155           
=========================================
  Hits            608      608           
  Misses           61       61           
  Partials         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd51946...5c54098. Read the comment docs.

Copy link
Copy Markdown
Member

@fwdekker fwdekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@fwdekker fwdekker merged commit dc5ceb6 into master Jun 1, 2018
@fwdekker fwdekker deleted the test-visibility branch June 1, 2018 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

code quality Code quality improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants