Merged
Conversation
a56ba7d to
5b7829a
Compare
Owner
Author
|
Updated after CI exposed an unrelated order assumption in test_hermes_adapter on one runner. Root cause: the test asserted literal fact IDs even though the retrieval order can tie differently across SQLite/Python environments. The amended test now asserts adapter output follows packet.retrieval_trace order and still verifies all three created facts are included. Re-ran full local verification: focused 2 passed, full tests 175 passed, release metadata/readiness, npm dry-run, diff check, node check, secret scan finding_count=0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-memory observations empty-diagnosticsfor high empty retrieval ratio dogfood triageSafety / privacy
Verification
empty-diagnosticswas not a valid observations subcommandTMPDIR=$PWD/.tmp-test uv run pytest tests/test_cli.py::test_python_module_cli_observations_empty_diagnostics_groups_empty_segments_without_raw_queries -q4 passedTMPDIR=$PWD/.tmp-test uv run pytest tests/ -q->175 passeduv run python scripts/check_release_metadata.pyuv run python scripts/smoke_release_readiness.pynpm pack --dry-rungit diff --checknode --check bin/agent-memory.jsobservations empty-diagnostics /Users/reddit/.agent-memory/memory.db --limit 200 --top 10 --high-empty-threshold 0.5->retrieval_empty_diagnostics True 38 13 0.3421finding_count=0