Add build+test CI,rustfmt.toml, various minor fixes and formatting#1
Merged
cairoeth merged 4 commits intocairoeth:mainfrom Jan 12, 2024
Merged
Add build+test CI,rustfmt.toml, various minor fixes and formatting#1cairoeth merged 4 commits intocairoeth:mainfrom
rustfmt.toml, various minor fixes and formatting#1cairoeth merged 4 commits intocairoeth:mainfrom
Conversation
makemake-kbo
changed the title
rustfmt.toml, various minor fixes and formattingrustfmt.toml, various minor fixes and formatting
Owner
|
thanks @makemake-kbo! fixed the out of bounds bug and the workflow which was missing features |
cairoeth
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
rustfmt.tomlfor use withcargo +nightly fmtto enforce a strict coding style.I have also added a workflow for building and running unit tests.
Note: Unrelated to the PR but clippy produces a bunch of access out of bounds errors for the ERC20 impl. Probably something to be looked at. If not I recommend using
#[allow(clippy::out_of_bounds_indexing)]to silence it.