GH2196: Add repository element to nuspec file in NuGetPack tool#2167
Conversation
|
Having read more about SourceLink this may not actually be needed. If it's useful that's great but if not feel free to close |
|
Is there's an issue to go long with this PR? (as required per Contributing guidelines) |
|
Apologies I'd missed that part of the contrib guide. I'll put a note in Gitter now to see if this is something people are interested in and then get an issue raised if so. |
|
@rh072005 The reason for an issue is not (always) to get buy-in, but because we need an issue for our release process. I see no issue with adding this functionality so if you create an issue for this functionality we will merge it after a review 👍 |
| /// <summary> | ||
| /// Specifies the package's source code location, allowing IDEs to download and debug the code. | ||
| /// </summary> | ||
| public class NugetRepository |
There was a problem hiding this comment.
Shouldn't this be NuGetRepository instead?
There was a problem hiding this comment.
Good spot, I'll get it updated
|
Cheers @patriksvensson , that makes perfect sense. I've raised it as #2196 |
devlead
changed the title
devlead
force-pushed
the
feature-AddRepositoryElementToNuGetPack
branch
from
6041579 to
a2ed04d
Compare
…develop * rh072005-feature-AddRepositoryElementToNuGetPack: Add repository metadata element to nuget pack * Fixes #2167
|
@rh072005 your changes have been merged, thanks for your contribution 👍 |
* release/0.29.0: (build) Updated version and release notes. (GH-2094) Allow no dependecy exec of single task * fixes #2094 Change the legacy pattern validation. Do not rely on Uri.TryCreate, use a regex instead. This will fix the absolute path handling issues. Add tests for testing legacy and new patterns with relative and absolute pathes on all platform. (GH-2193) Added new maintainers (GH-2203) Added Octopus Deploy release promotion * fixes #2203 (GH-2095) NUnit Skip non test assemblies * Add --skipnontestassemblies funcionality to CAKE's NUnit3Settings as it exists in original nunit3 test runner * Fixes #2095 Initial implementation of PushTestResults and PublishCodeCoverage Add repository metadata element to nuget pack * Fixes #2167 Made SelfContained a nullable boolean since no setting means it takes the .Net default of true when runtime is included. Added the logic to include false for self contain and test Fixes #2140 try resolve vstest.console.exe before guessing it Try to find vswhere.exe on the system if the tool is not registered. changed the recommended tool for the WiX package in the documentation (build) Updated Cake tool to version 0.28.1 (GH-2188) Corrected link to CLA (build) Updated Cake tool to version 0.28.0
4 participants
No description provided.