GH2193: Added new maintainers#2194
Merged
daveaglick merged 1 commit intocake-build:developfrom Jun 25, 2018
Merged
Conversation
Member
Author
|
Relates to #2193 |
pascalberger
approved these changes
Jun 17, 2018
Member
Author
|
@pascalberger if you are happy with this change, then you can feel free to merge it. For a larger, code related change, we might need a couple of thumbs up, but for this, I think we are good to go. |
Member
Author
|
The process that we follow for Cake is going to be similar to what you already follow for your other repos, but, main things would be:
Let me know if you have any questions. |
devlead
changed the title
devlead
approved these changes
Jun 20, 2018
Member
devlead
left a comment
devlead
left a comment
There was a problem hiding this comment.
@gep13 LGTM 👍
@pascalberger & @daveaglick agree?
Member
|
I've been stalling on my review because honestly, I was hoping to be listed as CodeNinja McGooglyEyes. I guess this will suffice though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Think I have got all the required places