Use repl package and remove mobiledetect#829
Merged
othercorey merged 1 commit into4.nextfrom Mar 15, 2021
Merged
Conversation
othercorey
reviewed
Mar 8, 2021
ADmad
reviewed
Mar 8, 2021
Member
A lot of those developing CMSs would need it, probably more than the repl feature :) |
Member
Author
|
@ADmad Fair point I've put mobiledetect back. |
garas
reviewed
Mar 15, 2021
raul338
reviewed
Mar 15, 2021
othercorey
reviewed
Mar 15, 2021
Instead of shipping the console command with the application skeleton using a separate package will allow us to deliver fixes to the console command in a reasonable way. It also enables us to provide more shortcut functions for use in the repl and development mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of shipping the console command with the application skeleton using a separate package will allow us to deliver fixes to the console command in a reasonable way. It also enables us to provide more shortcut functions for use in the repl and development mode.
I've removed mobiledetect as a direct dependency. I don't think it gets a ton of usage by users and it can live on as a comment and optional package that can be installed as necessary.