Update application skeleton for new fixtures.#843
Merged
Conversation
Using the schema dump file is not ideal. Once cakephp/migrations#488 is merged I will update this to use migrations instead.
Contributor
|
Looks ok. |
ADmad
reviewed
Jun 15, 2021
| // | ||
| // If you want to support multiple databases, consider | ||
| // using migrations to provide schema for your plugin, | ||
| // and using \Migrations\TestSuite\Migrator to load schema. |
Member
There was a problem hiding this comment.
Would be nice to have a code e.g. for this too.
Member
Author
There was a problem hiding this comment.
I'm going to add it later this week. That will be the 'default' mode for applications as I think re-using migrations is a better dev experience than having to generate a dump file. I was blocked on the migrations changes not being merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the schema dump file is not ideal. Once cakephp/migrations#488 is merged I will update this to use migrations instead.