Skip to content

Import Cake\Codeception\Console\Installer#862

Merged
ADmad merged 2 commits intocakephp:masterfrom
szepeviktor:patch-2
Oct 13, 2021
Merged

Import Cake\Codeception\Console\Installer#862
ADmad merged 2 commits intocakephp:masterfrom
szepeviktor:patch-2

Conversation

@szepeviktor
Copy link
Copy Markdown
Contributor

Minus one variable 🚀

@szepeviktor szepeviktor marked this pull request as draft October 13, 2021 02:16
@szepeviktor szepeviktor marked this pull request as ready for review October 13, 2021 02:17
@ADmad ADmad merged commit 5818a80 into cakephp:master Oct 13, 2021
@szepeviktor
Copy link
Copy Markdown
Contributor Author

Thank you.

@szepeviktor szepeviktor deleted the patch-2 branch October 13, 2021 02:40
@othercorey
Copy link
Copy Markdown
Contributor

Should we even suggest this anymore?

@ADmad
Copy link
Copy Markdown
Member

ADmad commented Oct 13, 2021

Probably not, the codeception plugin isn't maintained.

@LordSimal
Copy link
Copy Markdown
Contributor

The class Cake\Codeception\Console\Installer doesn't seem to exist for me. I am on CakePHP 4.3.
Or am I missing something?

@ndm2
Copy link
Copy Markdown
Contributor

ndm2 commented Nov 6, 2021

It's in the codeception plugin.

@LordSimal
Copy link
Copy Markdown
Contributor

I was just confused to see code/use statements which are not resolvable in the "base" app template because the plugin is not in the composer.json

If this is intended then forget that I asked 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants