Merged
Conversation
Member
Author
|
Well, that's interesting. I have no idea why all of the sudden the whole file changed. |
Contributor
|
All line endings changed to |
Member
|
Windows people :) |
Member
|
Or maybe a git setting (default) here on local system? |
Member
Author
|
I actually did this change via the web UI of Github. |
garas
reviewed
Jan 24, 2022
Comment on lines
+16
to
+18
| # Icon must end with two \r | ||
| Icon | ||
|
|
Member
There was a problem hiding this comment.
You've also lost \r here, comment warns to be careful here
Member
There was a problem hiding this comment.
The mixed line endings are probably why github UI switched the line ending on you.
9fe25b5 to
bf03fef
Compare
Member
Author
|
Looks better now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.