Skip to content

Update .gitignore#882

Merged
markstory merged 2 commits into4.xfrom
update-gitignore
Jan 26, 2022
Merged

Update .gitignore#882
markstory merged 2 commits into4.xfrom
update-gitignore

Conversation

@cleptric
Copy link
Copy Markdown
Member

No description provided.

@cleptric
Copy link
Copy Markdown
Member Author

Well, that's interesting. I have no idea why all of the sudden the whole file changed.

@ndm2
Copy link
Copy Markdown
Contributor

ndm2 commented Jan 24, 2022

All line endings changed to CRLF.

@dereuromark
Copy link
Copy Markdown
Member

Windows people :)

@dereuromark
Copy link
Copy Markdown
Member

Or maybe a git setting (default) here on local system?

@cleptric
Copy link
Copy Markdown
Member Author

I actually did this change via the web UI of Github.

Comment thread .gitignore Outdated
Comment on lines +16 to +18
# Icon must end with two \r
Icon

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've also lost \r here, comment warns to be careful here

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixed line endings are probably why github UI switched the line ending on you.

@saeideng saeideng added this to the 4.x milestone Jan 25, 2022
@cleptric
Copy link
Copy Markdown
Member Author

Looks better now :)

@markstory markstory merged commit 6e5a382 into 4.x Jan 26, 2022
@markstory markstory deleted the update-gitignore branch January 26, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants