Conversation
- Update AbstractIdentifier::CREDENTIAL_* to PasswordIdentifier::CREDENTIAL_* - Add missing return types to code examples (initialize(), _setPassword()) - Fix broken tutorial link to use absolute CakePHP Book URL - Replace deprecated strpos() with str_starts_with() - Update API link from CakePHP 4.0 to 5 - Remove misleading identifier config from Session authenticator examples - Remove outdated "Added in version 2.10.0" notes - Add missing use statement for JWT in JwksController example - Fix typo in jwt.pem path (./jwt.pem -> /jwt.pem) - Use strict comparison (===) instead of loose (==) - Add missing MiddlewareQueue type hints in migration guide - Remove unused ResponseInterface import - Add missing documentation links in contents.md (redirect-validation, upgrade-3-to-4)
dereuromark
commented
Apr 2, 2026
- Remove CONFIG double slash (CONFIG . '/jwt.key' -> CONFIG . 'jwt.key')
- Fix 'explicity' typo -> 'explicitly'
- Remove trailing comma from nonce default value
- Update route syntax to CakePHP 5 ({controller} instead of :controller)
- Remove Session authenticator identifier config (Session doesn't use identifiers)
- Remove outdated loadIdentifier() references (removed in 4.x)
- Fix grammar: 'an user' -> 'a user'
- Add return types to IdentityInterface method examples
- Update IdentifierCollection reference to reflect 4.x architecture
- Remove outdated ResponseInterface from docblock
- Use named arguments for finder: find('byToken', token: $token)
- Use string instead of array for request->is('post')
Contributor
|
maybe wait with this merge after #779 is in because it fixed a bunch of linting errors |
Member
Author
|
I would do the other way around. More important to get the wrong Infos fixed i guess |
- Add return types to all controller action examples (login, logout, etc.) - Fix "Let's" grammar (was "Lets") - Fix `stopImpersonation()` typo -> `stopImpersonating()` - Replace deprecated `TableRegistry::getTableLocator()->get()` with `fetchTable()` - Fix indentation inconsistency in testing examples - Add missing redirect return in revertIdentity() example - Use `fetchTable()` instead of `$this->Users` property access - Use `saveOrFail()` instead of `save()` for better error handling - Use `'plugin' => false` instead of `'plugin' => null` for consistency - Add trailing commas in arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First Pass
AbstractIdentifier::CREDENTIAL_*toPasswordIdentifier::CREDENTIAL_*(constants moved in 4.x)initialize(): void,_setPassword(): string)strpos()withstr_starts_with()(PHP 8+)identifierconfig fromSessionauthenticator examples (Session doesn't use identifiers)use Firebase\JWT\JWT;statement in JwksController example===) instead of loose (==)MiddlewareQueuetype hints in migration guideResponseInterfaceimportredirect-validation,upgrade-3-to-4)Second Pass
CONFIG . '/jwt.key'->CONFIG . 'jwt.key'){controller}instead of:controller)loadIdentifier()references (method removed in 4.x)IdentityInterfacemethod examplesIdentifierCollectionreference to reflect 4.x architecture (now uses single identifier)ResponseInterfacefrom docblock parameterfind('byToken', token: $token)request->is('post')Third Pass
login(),logout(),beforeFilter(), etc.)stopImpersonation()typo ->stopImpersonating()TableRegistry::getTableLocator()->get()withfetchTable()revertIdentity()examplefetchTable()instead of$this->Usersproperty accesssaveOrFail()instead ofsave()for better error handling'plugin' => falseinstead of'plugin' => nullfor consistency