CakePHP 3.6 Upgrade (continued) #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatibility issues Changelogs summary: - josegonzalez/cakephp-upload updated from 3.8.1 to 4.0.0 See changes: FriendsOfCake/cakephp-upload@3.8.1...4.0.0 Release notes: https://github.com/FriendsOfCake/cakephp-upload/releases/tag/4.0.0
Changelogs summary: - sebastian/version installed in version 2.0.1 Release notes: https://github.com/sebastianbergmann/version/releases/tag/2.0.1 - sebastian/resource-operations installed in version 1.0.0 Release notes: https://github.com/sebastianbergmann/resource-operations/releases/tag/1.0.0 - sebastian/object-reflector installed in version 1.1.1 Release notes: https://github.com/sebastianbergmann/object-reflector/releases/tag/1.1.1 - sebastian/recursion-context installed in version 3.0.0 Release notes: https://github.com/sebastianbergmann/recursion-context/releases/tag/3.0.0 - sebastian/object-enumerator installed in version 3.0.3 Release notes: https://github.com/sebastianbergmann/object-enumerator/releases/tag/3.0.3 - sebastian/global-state installed in version 2.0.0 Release notes: https://github.com/sebastianbergmann/global-state/releases/tag/2.0.0 - sebastian/exporter installed in version 3.1.0 Release notes: https://github.com/sebastianbergmann/exporter/releases/tag/3.1.0 - sebastian/environment installed in version 3.1.0 Release notes: https://github.com/sebastianbergmann/environment/releases/tag/3.1.0 - sebastian/diff installed in version 2.0.1 Release notes: https://github.com/sebastianbergmann/diff/releases/tag/2.0.1 - sebastian/comparator installed in version 2.1.3 Release notes: https://github.com/sebastianbergmann/comparator/releases/tag/2.1.3 - doctrine/instantiator installed in version 1.1.0 Release notes: https://github.com/doctrine/instantiator/releases/tag/1.1.0 - phpunit/php-text-template installed in version 1.2.1 Release notes: https://github.com/sebastianbergmann/php-text-template/releases/tag/1.2.1 - phpunit/phpunit-mock-objects installed in version 5.0.10 Release notes: https://github.com/sebastianbergmann/phpunit-mock-objects/releases/tag/5.0.10 - phpunit/php-timer installed in version 1.0.9 Release notes: https://github.com/sebastianbergmann/php-timer/releases/tag/1.0.9 - phpunit/php-file-iterator installed in version 1.4.5 Release notes: https://github.com/sebastianbergmann/php-file-iterator/releases/tag/1.4.5 - theseer/tokenizer installed in version 1.1.0 Release notes: https://github.com/theseer/tokenizer/releases/tag/1.1.0 - sebastian/code-unit-reverse-lookup installed in version 1.0.1 Release notes: https://github.com/sebastianbergmann/code-unit-reverse-lookup/releases/tag/1.0.1 - phpunit/php-token-stream installed in version 2.0.2 Release notes: https://github.com/sebastianbergmann/php-token-stream/releases/tag/2.0.2 - phpunit/php-code-coverage installed in version 5.3.2 Release notes: https://github.com/sebastianbergmann/php-code-coverage/releases/tag/5.3.2 - webmozart/assert installed in version 1.3.0 Release notes: https://github.com/webmozart/assert/releases/tag/1.3.0 - phpdocumentor/reflection-common installed in version 1.0.1 Release notes: https://github.com/phpDocumentor/ReflectionCommon/releases/tag/1.0.1 - phpdocumentor/type-resolver installed in version 0.4.0 Release notes: https://github.com/phpDocumentor/TypeResolver/releases/tag/0.4.0 - phpdocumentor/reflection-docblock installed in version 4.3.0 Release notes: https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/4.3.0 - phpspec/prophecy installed in version 1.8.0 Release notes: https://github.com/phpspec/prophecy/releases/tag/1.8.0 - phar-io/version installed in version 1.0.1 Release notes: https://github.com/phar-io/version/releases/tag/1.0.1 - phar-io/manifest installed in version 1.0.1 Release notes: https://github.com/phar-io/manifest/releases/tag/1.0.1 - myclabs/deep-copy installed in version 1.8.1 Release notes: https://github.com/myclabs/DeepCopy/releases/tag/1.8.1 - phpunit/phpunit installed in version 6.5.13 Release notes: https://github.com/sebastianbergmann/phpunit/releases/tag/6.5.13
Plus add minimal file header doc block
Changelogs summary: - squizlabs/php_codesniffer updated from 2.9.1 to 3.3.2 See changes: squizlabs/PHP_CodeSniffer@2.9.1...3.3.2 Release notes: https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.3.2 - cakephp/cakephp-codesniffer updated from 2.4.0 to 3.0.5 See changes: cakephp/cakephp-codesniffer@2.4.0...3.0.5 Release notes: https://github.com/cakephp/cakephp-codesniffer/releases/tag/3.0.5
Merged
Member
Author
|
What can I do to push this forward? |
Contributor
|
@ravage84 I had missed this, I am doing some tests now in stage before merging into master. |
Contributor
|
@ravage84 the only deprecated now are the ones from ImagineBehavior https://gist.github.com/yeliparra/b7745257af9de3eeb03f4bec8894fc0e It seems burzum/cakephp-imagine-plugin needs to be upgraded to "^3.0", now it's using "~2.0". |
Member
Author
|
The latest release of Burzum's ImagineBehavior plugin is 2.1.1 https://github.com/burzum/cakephp-imagine-plugin/releases/tag/2.1.1 I'm not sure there is a compatible (as in not using deprecated methods) version of that plugin... 🤷♂️ |
Contributor
|
@ravage84 what about using branch 3.x? I think that one would work. |
Member
Why not just turn off deprecation warnings reporting in app config? |
Contributor
|
that is another option, but we will have to live with those deprecates. We could do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building @yeliparra 's changes in the stage branch after she took my work from #118 .