Merged
Conversation
Contributor
Author
|
That stan issue is correct imho. This if can't be reached, since that property is only typed to be |
Replace the vague type error on failure with a more explicit error message.
othercorey
reviewed
Jun 23, 2025
.github/workflows/ci.yml
Outdated
| - name: Code Coverage Report | ||
| if: success() && matrix.php-version == '8.1' && matrix.dependencies == 'highest' | ||
| uses: codecov/codecov-action@v5 | ||
| uses: cakephp/.github/.github/workflows/testsuite-with-db.yml@5.x |
Contributor
There was a problem hiding this comment.
I don't think we need db
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why the testsuite wasn't using our central template but I didn't find any discrepencies with what was present right now.